Skip to content

[PWGLF] readded photon selection of e+- and improved pi0 selection#16944

Merged
maciacco merged 4 commits into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:its_new
Jul 8, 2026
Merged

[PWGLF] readded photon selection of e+- and improved pi0 selection#16944
maciacco merged 4 commits into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:its_new

Conversation

@GiorgioAlbertoLucia

@GiorgioAlbertoLucia GiorgioAlbertoLucia commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwglf label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 75 errors, ⚠️ 102 warnings, 🔕 0 disabled

@GiorgioAlbertoLucia GiorgioAlbertoLucia marked this pull request as ready for review July 7, 2026 11:33
@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 9046f04 at 2026-07-07 15:22:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 8 errors and 55 warnings.'
Found 8 errors and 55 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/a079b29444c77f74091a00cefb460747d90b034b/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:78:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:148:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:166:8: error: constructor does not initialize these fields: m_ccdb, m_runNumber, m_d_bz, m_BBparamsDe, m_BBparamsHe [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:254:92: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:337:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:399:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:691:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:723:43: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
++ [[ 55 -gt 0 ]]
++ cat /sw/BUILD/a079b29444c77f74091a00cefb460747d90b034b/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:344:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:346:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:348:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:350:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:352:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:360:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:362:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:364:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:366:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:368:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:370:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:378:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:380:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:382:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:384:85: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:386:73: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:388:82: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:390:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:392:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:394:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:398:79: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:424:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:426:128: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:428:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:437:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:439:128: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:441:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:570:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:703:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:707:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:751:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:787:47: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@GiorgioAlbertoLucia
Correct mass calculation for Pi0 in LFTreeCreator
35b1c47 
Fix calculation of mass for Pi0 particles in analysis.
@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 35b1c47 at 2026-07-07 16:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:1126:143: error: expected ';' before ')' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 35b1c47 at 2026-07-07 16:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:1126:143: error: expected ';' before ')' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 35b1c47 at 2026-07-07 16:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:1126:143: error: expected ';' before ')' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 81d6fc9 at 2026-07-08 09:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:1126:143: error: expected ')' before ';' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 81d6fc9 at 2026-07-08 09:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:1126:143: error: expected ')' before ';' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 81d6fc9 at 2026-07-08 09:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:1126:143: error: expected ')' before ';' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 36f175c at 2026-07-08 11:38:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 8 errors and 55 warnings.'
Found 8 errors and 55 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/8ff1b9b7237e43800bfc231975dd98be9cd00c7a/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:78:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:148:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:166:8: error: constructor does not initialize these fields: m_ccdb, m_runNumber, m_d_bz, m_BBparamsDe, m_BBparamsHe [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:254:92: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:337:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:399:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:691:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:723:43: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
++ [[ 55 -gt 0 ]]
++ cat /sw/BUILD/8ff1b9b7237e43800bfc231975dd98be9cd00c7a/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:344:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:346:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:348:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:350:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:352:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:360:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:362:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:364:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:366:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:368:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:370:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:378:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:380:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:382:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:384:85: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:386:73: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:388:82: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:390:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:392:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:394:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:398:79: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:424:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:426:128: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:428:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:437:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:439:128: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:441:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:570:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:703:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:707:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:751:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:787:47: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

maciacco
maciacco approved these changes Jul 8, 2026
View reviewed changes

@maciacco maciacco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GiorgioAlbertoLucia please fix linter error at the next iteration

@maciacco maciacco merged commit 16e8134 into AliceO2Group:master Jul 8, 2026
11 of 15 checks passed
@GiorgioAlbertoLucia GiorgioAlbertoLucia deleted the its_new branch July 8, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maciacco maciacco maciacco approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GiorgioAlbertoLucia @alibuild @maciacco